Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users from setting non-image files as a background image #2205

Closed
Davidy22 opened this issue Oct 7, 2023 · 7 comments · Fixed by #2207
Closed

Prevent users from setting non-image files as a background image #2205

Davidy22 opened this issue Oct 7, 2023 · 7 comments · Fixed by #2207

Comments

@Davidy22
Copy link
Collaborator

Davidy22 commented Oct 7, 2023

As noticed in #2198 and #2201, this is currently possible and causes a crash bug. Add a check to stop users from setting non-image files in the background selection dialog

@HeetVekariya
Copy link

Is this issue solved or not ?
If not then can you please locate the file/functions which is to corrected such that it only allows the image file to be set as background files.

@kapami
Copy link

kapami commented Oct 7, 2023

Hello, I would like to work on this issue. Can you please assign me to this issue?
Thank you

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Oct 8, 2023

You don't need to wait to be assigned anything, just send in a PR that fixes an issue and link it.

@HeetVekariya
Copy link

@Davidy22 how can i connect with you on the discord ?

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Oct 8, 2023

Is there something you want to discuss that isn't related to this issue?

@HeetVekariya
Copy link

I want to know what is to be changed such that the issue is solved. For that i want to join the discord of this repo if exist.

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Oct 8, 2023

Anything relevant to this issue can be discussed here. You should be able to find what you need to change by searching for the word background, probably just need to change the code around the dialog in prefs.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants