Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 21 LTS support #331

Closed
xberkhout opened this issue Apr 12, 2023 · 8 comments
Closed

JDK 21 LTS support #331

xberkhout opened this issue Apr 12, 2023 · 8 comments

Comments

@xberkhout
Copy link

The next Java release 21 (https://jdk.java.net/21/) will be an LTS release and to test early with virtual threads it would welcome if ProGuard would already support the internal version 65 so I can integrate it in my build system. Of course a beta is enough.

I fully understand that now might be a bit early, but if it could be done when possible and at the latest together with the first release candidate of JDK 21 (https://openjdk.org/projects/jdk/21/), so early August that would be great.

Thank you already and kind regards,

Xander

@ansalond
Copy link

ansalond commented Jun 5, 2023

Is there any ETA about preliminary support for JDK21?

For your information, I plan to run some tests with the following changes: Guardsquare/proguard-core@master...graalvm:proguard-core:da/jdk21

Of course this would only be a temporary workaround and I look forward to one of your snapshot builds.

Thanks!

@mrjameshamilton
Copy link
Collaborator

Hi @ansalond !

As far as I can tell, there's nothing in JDK21 that requires any special handling by ProGuard (for example, new class file attirbutes or bytecode instructions) so the changes you made should be sufficient. Can you make a PR?

Thanks!

@ansalond
Copy link

ansalond commented Jun 6, 2023

Hello @mrjameshamilton, thank you for the quick reply.

Here is the PR: Guardsquare/proguard-core#92

Thanks!

@mrjameshamilton
Copy link
Collaborator

Thanks @ansalond ! Next I'll need to make a ProGuardCORE release and then update the dependency in ProGuard, then make a ProGuard release.

@xberkhout
Copy link
Author

What is your estimation, when you could have a beta or release available?

@mrjameshamilton
Copy link
Collaborator

Hi @xberkhout ! I've made a 7.4.0-beta01 release ; it'll be on Maven Central soon.

@xberkhout
Copy link
Author

Thank you very much. I will test it the coming days with the Early Access of OpenJDK 21 in my build process.

@xberkhout
Copy link
Author

xberkhout commented Aug 12, 2023

I have tested it with the first Release Candidate of JDK 21 (https://jdk.java.net/21/) and it works very well. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants