Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile is broken with color change #86

Open
chrissimpkins opened this issue Sep 2, 2022 · 1 comment
Open

Compile is broken with color change #86

chrissimpkins opened this issue Sep 2, 2022 · 1 comment

Comments

@chrissimpkins
Copy link

chrissimpkins commented Sep 2, 2022

The fontmake compiler raises an error about a missing default master in https://github.com/Gue3bara/Cairo/runs/8157091361?check_suite_focus=true at commit 246a5c5

fontmake.errors.FontmakeError: In 'CairoNormal.glyphs' -> 'master_ufo/Cairo.designspace': Generating fonts from Designspace failed: Can't find base (neutral) master in DesignSpace document

Maybe it is getting hung up on the following weight axis default location definition?

    <axis tag="wght" name="weight" minimum="200" maximum="1000" default="457.894737">
      <map input="200" output="36"/>
      <map input="300" output="50"/>
      <map input="400" output="0"/>
      <map input="500" output="88"/>
      <map input="600" output="96"/>
      <map input="700" output="138"/>
      <map input="800" output="158"/>
      <map input="900" output="178"/>
      <map input="1000" output="232"/>
    </axis>
@chrissimpkins
Copy link
Author

chrissimpkins commented Sep 2, 2022

If I re-define the designspace axis configuration to the following, the build completes successfully and I see your color palette change in the variable font:

    <axis tag="wght" name="weight" minimum="200" maximum="1000" default="400">
      <map input="200" output="36"/>
      <map input="300" output="50"/>
      <map input="400" output="80"/>
      <map input="500" output="88"/>
      <map input="600" output="96"/>
      <map input="700" output="138"/>
      <map input="800" output="158"/>
      <map input="900" output="178"/>
      <map input="1000" output="232"/>
    </axis>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant