Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium Testing #58

Merged
merged 1 commit into from Jan 14, 2017
Merged

Conversation

ameliavoncat
Copy link
Contributor

No description provided.

Copy link
Contributor

@jaredatron jaredatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks awesome. please merge once that one change is made :)

@@ -23,26 +27,43 @@ server.use(bodyParser.json())
server.use(require('./authentication'))
server.use('/api', require('./api'))

if(process.env.NODE_ENV === 'test') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this into authentication.js?

}
response.send(`
logged in as ${githubId}
${JSON.stringify(request.session, null, 4)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove line 42

@ameliavoncat ameliavoncat merged commit 46d7255 into LearnersGuild:master Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants