New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing assertion for "Should be able to get timestamp Redemption Code Hash " #2

Closed

aakilfernandes opened this issue Jan 22, 2019 · 1 comment

Contributor

aakilfernandes commented Jan 22, 2019

https://github.com/GuildCrypt/oathforge/blob/quillhash-audit/test/web3/oathForge.js#L219-L223

There is no assert in the test case

abhisharma1357 commented Jan 22, 2019

Most of the places where assertion is not used , console log is used to compare values that are used as a input or assumed to be in output.

aakilfernandes closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment