Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't clean submodules before creating branch #10

Open
daquinteroflex opened this issue Jan 9, 2024 · 1 comment
Open

Doesn't clean submodules before creating branch #10

daquinteroflex opened this issue Jan 9, 2024 · 1 comment

Comments

@daquinteroflex
Copy link

Currently, when the action is checked out, it checks out from the base directory which may include sub modules that are not in the new_branch_ref branch and it does not clean that history. This creates issues onwards.

@GuillaumeFalourd
Copy link
Owner

GuillaumeFalourd commented Jan 9, 2024

Thank you for opening the issue @daquinteroflex 🚀

I may not be able to correct this right away though 😨

I observed in you commentary on the flexcompute/tidy3d repository that you could eventually "sit down and fix the action for our intentions". I don't know how urgent it is, but feel free to contribute to the action (even if not for this issue). The more contributors, the better! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants