Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "rust-version" field in Cargo.toml (when stable) #590

Closed
GuillaumeGomez opened this issue Oct 15, 2021 · 8 comments
Closed

Add "rust-version" field in Cargo.toml (when stable) #590

GuillaumeGomez opened this issue Oct 15, 2021 · 8 comments

Comments

@GuillaumeGomez
Copy link
Owner

The RFC for this feature is there and the documentation is there.

@poliorcetics
Copy link
Contributor

Update: This has become stable with Rust 1.56 but sysinfo minimum rust-version at this time is 1.54 so still not possible.

@GuillaumeGomez
Copy link
Owner Author

Wanna send a PR to fix it? :)

I'm waiting for a libc PR to be merged before making the next release in any case but that would still be one less thing to worry about.

@poliorcetics
Copy link
Contributor

I'm okay with doing a PR but it means updating the MSRV, do you want to do this ?

@GuillaumeGomez
Copy link
Owner Author

It isn't an issue. Unknown fields don't prevent cargo to work and don't emit warnings either, they're just ignored. No need to update the MSRV.

@poliorcetics
Copy link
Contributor

The doc linked says rust-version will produce a warning when present but on less than 1.56

The first version of Cargo that supports this field was released with Rust 1.56.0. In older releases, the field will be ignored, and Cargo will display a warning.

I can't test right now, will do when getting home

@GuillaumeGomez
Copy link
Owner Author

👍

@poliorcetics
Copy link
Contributor

This has been done and can be closed, sorry I didn't come back to you when I said I would

@GuillaumeGomez
Copy link
Owner Author

Fixed in #605.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants