Something broke on 5.1.67 #91
Comments
|
My addon (https://github.com/pikdum/plugin.video.haru) is also broken after upgrading to 5.1.67. Seems to be related to this: After opening up my addon, and opening up 'SubPlease - Airing', Kodi crashes. Commenting out the Not sure if same exact issue as above. |
|
@cywteow @pikdum |
|
Looks like my issue was fixed with d2a13cc. |
|
Wow i missed all the fun today :) Think the bigger issue he is having is here: He has his own resolvers and those imports need to be fixed. |
|
@cywteow |
|
@Gujal00 Happy to assist when i can :P |
|
As it seems, this last update had so many changes that it should get a major version bump to 5.2.x instead of staying at 5.1.x. Uwc (unmaintained for 1+ year now) broke for me, but changing line 60 of |
|
Maybe there's an easy way to maintain backwards compatibility by having both the old + new import paths working? |
|
@pikdum You are right, a path change could affect many old/unmaintained addons to be broken. @Gujal00 you can consider to make both paths to be compatible. @shellc0de27 Thanks for the help! |
|
@Gujal00, regarding op's issue - well not an issue actually, just log spamming as resolvers and their settings come and go and leave obsolete settings entries on user's (userdata) settings.xml, what'd you think about a function like this: |
|
The whole idea was to consolidate all the libraries into one folder rather than having them split in two different places, no reason why it was like that in the first place. @cywteow I do not know why you have fcdn resolver separately. It is already supported in Fembed resolver class FEmbedResolver(ResolveUrl):
name = "FEmbed"
domains = ["fembed.com", "anime789.com", "24hd.club", "vcdn.io", "sharinglink.club", "votrefiles.club",
"femoload.xyz", "feurl.com", "dailyplanet.pw", "jplayer.net", "xstreamcdn.com", "gcloud.live",
"vcdnplay.com", "vidohd.com", "vidsource.me", "votrefile.xyz", "zidiplay.com", "fcdn.stream",
"mediashore.org", "there.to", "femax20.com", "sexhd.co", "viplayer.cc", "mrdhan.com", "votrefilms.xyz",
"embedsito.com", "dutrag.com", "youvideos.ru", "streamm4u.club", "moviepl.xyz", "asianclub.tv",
"vidcloud.fun", "fplayer.info", "diasfem.com", "fembad.org", "moviemaniac.org", "albavido.xyz",
"ncdnstm.com", "fembed-hd.com", "superplayxyz.club", "cinegrabber.com", "ndrama.xyz",
"javstream.top", "javpoll.com", "suzihaza.com", "fembed.net", "ezsubz.com", "reeoov.tube",
"diampokusy.com", "filmvi.xyz"]If you want to I could include the additional resolvers that you and @groggyegg maintain into the resolveurl base distribution, you only have two each not counting fcdn which is already covered |
|
My personal opinion on this.... |
Thanks, Good idea, I will have a look and see how it can be implemented safely and also possibly run silently whenever resolveurl updates, rather than give the user that option unnecessarily |
|
Yeah that's how I thought should be in the long run, I just made it as a temp settings action so it could be tested more easily. |
Offtopic. |
|
If that's what you prefer @pitsi but your missing the big picture. You and only you are running those risks cause Its not actively being maintained. |
|
Offtopic, part 2. Ontopic. |
|
@pitsi The version mentioned in the addon.xml if any is the minimum version required for operation, not themaximum version. So bumping resolverurl to even 6 is not going to fix the issue. |
@Gujal00 Thanks, I will do a PR later when I have time since the resolver's are not working for the time being. But regarding fcdn, if I don't remember it wrong, there were some issue with the existing resolver. It might have been fixed now, something that I have to try out first since it was a long time ago. |
I still do have custom plugins but I fixed the imports already. |
I know that detail. I am on kodi since the word "addon" was unknown to the kodi community and I have learned a lot by searching the kodi wiki and relevant resources for addons. |
|
@shellc0de27 @bleak-lodge For now I have kept it as manual option, but will look at possibility of running that function automatically whenever resolveurl gets updated |
|
@Gujal00 This works awesome. Did find 2 that it didn't clean based on my quick test. <setting id="VideozUpload_enabled" default="true">true</setting>
<setting id="VideozUpload_login" default="true">true</setting>
<setting id="VideozUpload_priority" default="true">100</setting>
<setting id="VidspaceResolve_enabled" default="true">true</setting>
<setting id="VidspaceResolve_login" default="true">true</setting>
<setting id="VidspaceResolve_priority" default="true">100</setting>Don't know why the settings entry for these doesn't include the word resolvers = set(re.findall(r'id="(.*?Resolver)_', settings_xml))Are you seeing the same on your end? |
|
@shellc0de27 Those defunct plugins had typos in the class name |
|
oh ok i see :) |
|
Yep, my observation as well. |
|
@shellc0de27 @bleak-lodge resolvers = set(re.findall(r'id="([A-Z][^"_]+)', settings_xml))Please test and if you are happy will release it |
|
@Gujal00 Yeah no problem. Can confirm new pattern removed those two. 👍 |
|
As per @bleak-lodge suggestion, in commit f933a5f the user settings cleanup function is now set to run silently when resolveurl updates you can test this by deleting the addon settings.xml file (not userdata resolveurl settings.xml), put back your old user settings.xml in userdata resolveurl folder then start smr link tester. It should then silently build a new addon settings.xml and based on that cleanup the userdata settings.xml |
|
@Gujal00 wouldn't it be safer to call |
The new xml is already in memory and the cleanup call is inside the if condition if old_xml != new_xml:So I thought it is time to cleanup anyway regardless if the addon settings xml is written or not. Do you thing there an issue with that approach? |
|
Ah yeah, you're right, |
5.1.66 still working fine
The text was updated successfully, but these errors were encountered: