Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace all federation directives #251

Closed
jturkel opened this issue Jun 1, 2023 · 2 comments
Closed

Namespace all federation directives #251

jturkel opened this issue Jun 1, 2023 · 2 comments

Comments

@jturkel
Copy link
Contributor

jturkel commented Jun 1, 2023

There's probably some history here but it would be nice to have consistent namespacing of federation directives. Currently @inaccessible and @tag are not namespaced but all other federation directives are namespaced e.g. @key is exposed as @federation__key. apollo-federation-ruby could make the set of imported directives configurable but I'm not sure there's sufficient value in doing that vs. just namespacing everything to avoid conflicts with other directives. I'd be happy to put up a PR if you're open to this change.

@grxy
Copy link
Collaborator

grxy commented Jun 1, 2023

This comment talks about why @inaccessible and @tag are imported vs namespaced.

@jturkel
Copy link
Contributor Author

jturkel commented Jun 1, 2023

Ah! Makes sense.

@grxy grxy closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants