Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional test frameworks (minitest) #13

Open
mzruya opened this issue Sep 15, 2019 · 0 comments
Open

Support additional test frameworks (minitest) #13

mzruya opened this issue Sep 15, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mzruya
Copy link
Collaborator

mzruya commented Sep 15, 2019

To support additional testing frameworks, we'll have to split this gem into a few sub-gems that live in the same repository.

My current thinking is that we'll have the following:

  • ar-query-matchers-rspec
    • would depend on the ar-query-matchers-core gem.
    • would have an RSpec dependency
    • in-charge of implementing and registering RSpec matchers
    • would include an RSpec integration test that uses the matchers
  • ar-query-matchers-minitest
    • would depend on the ar-query-matchers-core gem.
    • would have a Minitest dependency
    • in-charge of implementing and registering Minitest matchers
    • would include an Minitest integration test that uses the matchers
  • ar-query-matchers-core
    • would have no test framework dependencies
    • includes query instrumentation code. (all code currently under lib/ar_query_matchers/queries)
    • includes expectation formatting code. (all code currently inside the MatcherErrors module)

To keep backward compatibility, the ar-query-matchers gem could include ar-query-matchers-rspec as a default.

@mzruya mzruya changed the title Support minitest Support additional test frameworks (minitest) Sep 15, 2019
@mzruya mzruya added enhancement New feature or request help wanted Extra attention is needed labels Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant