Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to not install Git in Docker image #11

Open
ngan opened this issue Dec 2, 2020 · 1 comment
Open

Figure out how to not install Git in Docker image #11

ngan opened this issue Dec 2, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ngan
Copy link
Collaborator

ngan commented Dec 2, 2020

Currently, we're installing git to make buildkite-agent pipeline upload not print out a warning during the pipeline upload step. The agent CLI tries to fetch the commit SHA to set an environment variable (I'm not sure why).

@ngan ngan added the enhancement New feature or request label Dec 2, 2020
@ngan
Copy link
Collaborator Author

ngan commented Dec 5, 2020

Asked @JuanitoFatas

In rolling out Buildkite Builder, I noticed that the buildkite-agent pipeline upload command uses git to find the commit SHA so that it can set an environment variable. If git doesn’t exist,, then the upload operation still works but prints a warning. Some questions I had:

  1. Why does it need find the commit sha for the upload operation?
  2. Can I pass it in so that it doesn’t use git? I’m trying to not have to install git in our docker image.

Response:

Hi Ngan,
Buildkite Builder is cool. Thanks for your question!

  1. A build could be created by HEAD / FETCH_HEAD, then we need to resolve HEAD as commit sha Resolve BUILDKITE_COMMIT before pipeline upload buildkite/agent#871
  2. I am not sure and I will ask around. But I think agent assumes Git exists, so there are many places that use Git in the agent codebase.

I will let you know if I get more information about 2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant