Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about ADE/FDE in Table 1 & Supplementary Table 4. #4

Closed
WBMao opened this issue Jun 24, 2022 · 2 comments
Closed

Questions about ADE/FDE in Table 1 & Supplementary Table 4. #4

WBMao opened this issue Jun 24, 2022 · 2 comments

Comments

@WBMao
Copy link

WBMao commented Jun 24, 2022

Thanks for this interesting work! It seems that you use the wrong ADE/FDE results in the Table 1.

See: https://github.com/JoeHEZHAO/expert_traj#update-03282022

And I just wonder that whether the best ADE trajectory and the best FDE trajectory are the same one or not?

Also, it would be helpful if you can provide more details about the results in Supplementary Table 4, especially for the Sampling: 20 x 20.

The third question which bothers me a lot is the shape of the input. I use the shape of input: batch size, timestamps * feature dimension, which seems to be input: batch size, timestamps, feature dimension in your paper.

@Gutianpei
Copy link
Owner

Hello Weibo,

Thanks for the update of Expert's latest result, I'll reflect the update in next version of MID paper.

The best ADE trajectory and the best FDE trajectory are not same in our case.

The 20 x 20 sampling scheme is discussed here: JoeHEZHAO/expert_traj#1

I did not fully understand what "input" stands for, is it the input for the diffusion model?

@WBMao
Copy link
Author

WBMao commented Jul 3, 2022

Hi~ Tianpei,

Thanks for your reply!

In PECNet/YNet setting, the best ADE trajectory and FDE trajectory in SDD are same. BTW, they first pick the best FDE trajectory and calculate the ADE. And in my knowledge, the way to pick the trajectory will have a great impact on the final results.

And the 'input' stands for the input for the diffusion model, especially, the transformer architecture. (Probably I can find the answer from your codes~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants