fix(web): 404 error in console on avatar not found

Guusvanmeerveld · Nov 9, 2022 · ca1a898 · ca1a898
1 parent 0814829
commit ca1a898
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/apps/web/src/interfaces/http.d.ts b/apps/web/src/interfaces/http.d.ts
@@ -16,7 +16,7 @@ export default interface HttpClient {
 	refresh: (refreshToken: string) => Promise<LoginResponse>;
 	getBoxes: (token?: string) => Promise<BoxResponse[]>;
 	getPublicOAuthTokens: () => Promise<PublicTokensResponse>;
-	getAvatar: (address?: string) => Promise<string>;
+	getAvatar: (address?: string) => Promise<string | undefined>;
 	getBox: (
 		boxID: string,
 		pageParam: number,

diff --git a/apps/web/src/utils/hooks/useAvatar.ts b/apps/web/src/utils/hooks/useAvatar.ts
@@ -35,7 +35,7 @@ export default function useAvatar(
 	const blacklisted = !!noAvatar;
 
 	const { data, isLoading, error } = useQuery<
-		string,
+		string | undefined,
 		AxiosError<ErrorResponse>
 	>(
 		["avatar", email],

diff --git a/apps/web/src/utils/hooks/useFetch.ts b/apps/web/src/utils/hooks/useFetch.ts
@@ -153,11 +153,15 @@ const useHttpClient = (): HttpClient => {
 			return data;
 		},
 		async getAvatar(address) {
-			const { data } = await instance.get("/avatar", {
-				params: { address }
+			const res = await instance.get("/avatar", {
+				params: { address },
+				validateStatus: (status) =>
+					(status >= 200 && status < 300) || status == 404
 			});
 
-			return data;
+			if (res.status == 404) return;
+
+			return res?.data;
 		}
 	};
 };