Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DrawableRight and DrawableLeft references from xml #53

Merged
merged 4 commits into from
Apr 6, 2016
Merged

Remove DrawableRight and DrawableLeft references from xml #53

merged 4 commits into from
Apr 6, 2016

Conversation

stuxo
Copy link
Contributor

@stuxo stuxo commented Apr 4, 2016

Migrated extra drawables from xml to java, I overlooked DrawableRight and DrawableLeft it seems.

This should resolve the issue reported on the forums (reply dialog crashing)

@stuxo
Copy link
Contributor Author

stuxo commented Apr 5, 2016

@Twinklebear these should definitely be added to the release

@Twinklebear
Copy link
Collaborator

Are these fixes for the forum crash that someone mentioned?

I'll aim to merge this tonight and put out a new testing build

@stuxo
Copy link
Contributor Author

stuxo commented Apr 5, 2016

d2991c0 Fixes the "forum crash" when opening the reply dialog.
3f4e937 Fixes mismatched icons in the forums on light layout (sticky was a lock etc)
0ef2452 Added reply button programmatically (previously was hidden)
5f57906 Fixed white text on white background on light forum view (dark theme)

@Twinklebear Twinklebear merged commit 57d78cc into Gwindow:develop Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants