Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyLocation_Hash returns spurious exception value #45

Open
Hoikas opened this issue Jul 13, 2014 · 1 comment
Open

pyLocation_Hash returns spurious exception value #45

Hoikas opened this issue Jul 13, 2014 · 1 comment

Comments

@Hoikas
Copy link
Member

Hoikas commented Jul 13, 2014

pyLocation_Hash can return -1, Python's magical "hey there was an exception" value in cases when there is no error (there should never be an error for hashing locations). This value (and the exception) has been observed on default-inited plLocation objects.
@branan
Copy link
Member

branan commented Jul 13, 2014

It looks like it will also throw an exception when attempting to hash a location with a universal version set, since unparse is not defined for that.

We should probably just implement proper hashing of plLocation (prefix,page) instead of relying on unparse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@branan @Hoikas