Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos and spelling mistakes #2

Closed
wants to merge 1 commit into from
Closed

Fix some typos and spelling mistakes #2

wants to merge 1 commit into from

Conversation

garwil
Copy link

@garwil garwil commented Jul 8, 2021

Re: The Reddit comment linked below. I've started to correct some of the typos and spelling errors in the file. I might do some more later if there's any interest.

I wonder whether there's a need to curate some of the quotes though? There's multiple languages, and lots don't seem to fit the theme of the application.

https://www.reddit.com/r/commandline/comments/og4dzv/wisdom_tree_a_command_line_concentration_app/h4gytwp?utm_source=share&utm_medium=web2x&context=3

@Esamanoaz
Copy link
Contributor

I wonder whether there's a need to curate some of the quotes though? There's multiple languages, and lots don't seem to fit the theme of the application.

I agree. Checkout this line: Those sweet lips. My, oh my, I could kiss those lips all night long. Good things come to those who wait. The last sentence there could be inspirational. The first two are completely unrelated to the last and don't fit the inspiring/motivating/wise theme.

@shivanshu-semwal
Copy link

there is a typo in the README.md too

image

@HACKER097
Copy link
Owner

there is a typo in the README.md too

image

Not a typo, main.py is now in wisdom-tree/wisdom_tree/main.py

@HACKER097
Copy link
Owner

Re: The Reddit comment linked below. I've started to correct some of the typos and spelling errors in the file. I might do some more later if there's any interest.

I wonder whether there's a need to curate some of the quotes though? There's multiple languages, and lots don't seem to fit the theme of the application.

https://www.reddit.com/r/commandline/comments/og4dzv/wisdom_tree_a_command_line_concentration_app/h4gytwp?utm_source=share&utm_medium=web2x&context=3

Ok, this is a big issue, and cannot be done manually. I've removed all lines with non-English characters using perl, any ideas how we can get rid of typos? Maybe aspell could help.

@Esamanoaz
Copy link
Contributor

Most of the errors are punctuation errors. I can think of an idea for a python script that would go through character by character and solve that.

As for spelling errors, somebody could run a spellchecker like Grammarly through the file, or the Microsoft Word spell check.

I'll try to get on that today.

@Esamanoaz
Copy link
Contributor

Not a typo, main.py is now in wisdom-tree/wisdom_tree/main.py

I think shivanshu-semwal means that in the screenshot it is spelled wisdome with an e at the end.
Also, I will be sending a pull request soon. I wrote a script to edit the punctuation of the quotes.

@HACKER097
Copy link
Owner

Not a typo, main.py is now in wisdom-tree/wisdom_tree/main.py

I think shivanshu-semwal means that in the screenshot it is spelled wisdome with an e at the end.
Also, I will be sending a pull request soon. I wrote a script to edit the punctuation of the quotes.

aah, didnt see that, it has now been fixed

@HACKER097
Copy link
Owner

Very inspirational quote laughing "It is the destiny of the weak to be devoured by the strong."

Maybe time to get a new quote list? When I first made this one, I went with quantity over quality and scraped quotes from websites without reading them. With that said, here are a few of my favorites:-

Guys willing to hold your dick are a dime a dozen
Being born is like being kidnapped. And then sold into slavery.
Kill me, or you are a murderer.
You fuck - you ate my cat!
A girl always remembers the first corpse she shaves.

@HACKER097
Copy link
Owner

Closing this.

@HACKER097 HACKER097 closed this Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants