Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type stubs #122

Closed
yoav-orca opened this issue Sep 26, 2021 · 4 comments
Closed

Add support for type stubs #122

yoav-orca opened this issue Sep 26, 2021 · 4 comments

Comments

@yoav-orca
Copy link

Typing is becoming fairly popular in the python world, would you be open to accepting a PR adding type annotations?

@henriquebastos
Copy link
Collaborator

No. Tks

@colidyre
Copy link

FWIW: So I think to make the package PEP-561 compliant someone else have to write a stub package as mentioned for example at https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker.

If someone else is getting an error like this:

$ poetry run mypy --strict application.py app tests
app/settings.py:1: error: Skipping analyzing "decouple": module is installed, but missing library stubs or py.typed marker  [import]
app/settings.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

and has no time to write a stub package like me, you can add that code to ignore the "missing imports" failure to your pyproject.toml for this package:

[[tool.mypy.overrides]]
module = "decouple"
ignore_missing_imports = true

@shmulvad
Copy link

The missing type hints also started to annoy me. If you're interested, I created a fork of this repo that has added type hints: https://github.com/shmulvad/python-decouple-typed

It can be installed with pip install python-decouple-typed

@gotofritz
Copy link

Thanks @shmulvad - I don't get why @henriquebastos is against type definitions (why?!??), and the way he just closes or rejects PRs without even explaining why is rude and irritating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants