Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cumNormStat(lungData) not equal to 0.7014946. #87

Open
tillea opened this issue Aug 19, 2023 · 2 comments
Open

cumNormStat(lungData) not equal to 0.7014946. #87

tillea opened this issue Aug 19, 2023 · 2 comments

Comments

@tillea
Copy link

tillea commented Aug 19, 2023

Hi,
the Debian package received a bug report about two failed tests:

── Failure ('test-norm.R:28:3'): `cumNormStat` returns the correct value ───────
cumNormStat(lungData) not equal to 0.7014946.
names for target but not for current
── Failure ('test-norm.R:34:3'): `cumNormStatFast` returns the correct value ───
cumNormStatFast(lungData) not equal to 0.7014946.
names for target but not for current

[ FAIL 2 | WARN 6 | SKIP 0 | PASS 13 ]
Error: Test failures

Kind regards, Andreas.

@tillea
Copy link
Author

tillea commented Sep 5, 2023

Any idea what might be wrong here?

@charles-plessy
Copy link

--- a/tests/testthat/test-norm.R
+++ b/tests/testthat/test-norm.R
@@ -25,13 +25,13 @@
 
 test_that("`cumNormStat` returns the correct value", {
   data(lungData); data(mouseData);
-  expect_equal(cumNormStat(lungData),0.7014946)
+  expect_equal(unname(cumNormStat(lungData)),0.7014946)
   expect_equal(cumNormStat(mouseData),0.5)
 })
 
 test_that("`cumNormStatFast` returns the correct value", {
   data(lungData); data(mouseData);
-  expect_equal(cumNormStatFast(lungData),0.7014946)
+  expect_equal(unname(cumNormStatFast(lungData)),0.7014946)
   expect_equal(cumNormStatFast(mouseData),0.5)
 })
 

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants