Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you considered changing the name in the viostor json #400

Open
zjmletang opened this issue Jul 3, 2024 · 2 comments
Open

Have you considered changing the name in the viostor json #400

zjmletang opened this issue Jul 3, 2024 · 2 comments

Comments

@zjmletang
Copy link

the name is Red Hat VirtIO SCSI Disk Device
image

However, we noticed that during the HLK test, the default device name is 'Red Hat VirtIO SCSI controller'. If we use the current default name in the JSON, it might cause the HLK test to not find the device.
image

@kostyanf14
Copy link
Contributor

@zjmletang

First of all, we plan to remove drivers from the AutoHCK repo as this is more virtio-win-specific, something like a repo config for CI. Also, an organization can build drivers with other vendor strings but we specify RedHat.

Regarding your question, I don't understand why this happens for you because we use this config for our CI and it works.

In logs of virtio-win/kvm-guest-drivers-windows#1110 we can found:

I, [2024-06-25T12:10:09.003415 #265270]  INFO -- : Searching for target Red Hat VirtIO SCSI Disk Device (type 0) on CL1
I, [2024-06-25T12:10:10.099774 #265270]  INFO -- : Adding target Red Hat VirtIO SCSI Disk Device on CL1 to project viostor-Win2022x64
I, [2024-06-25T12:10:18.378409 #265270]  INFO -- : Applying microsoft's playlist

@zjmletang
Copy link
Author

@kostyanf14 ,
I'm not sure if this is as expected. It seems that if we use the default name, the device found might not be the controller but the disk device. The test items for these two are different. I understand that we should be testing the controller and not the disk device(If I am wrong, please point it out to me)

This is the HLK test list under the default name
image

This is the HLK test list under "Red Hat Virtio SCSI controller"
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants