h5dump doesn't honor HDF5_VOL_CONNECTOR.

[hyoklee]

Describe the bug
h5dump behaves differently when

1. setting HDF5_VOL_CONNECTOR=daos environment variable
2. providing --vol-name=daos

Expected behavior
Same behavior.

Platform (please complete the following information)

• HDF5 version: 1.14
• OS and version: n/a
• Compiler and version: n/a
• Build system (e.g. CMake, Autotools) and version: n/a
• Any configure options you specified: n/a
• MPI library and version (parallel HDF5): n/a

Additional context
Add any other context about the problem here.

The use_custom_vol_g is only active when --vol-name option is provided.

    if (use_custom_vol_g || use_custom_vfd_g) {
        if ((fapl_id = h5tools_get_fapl(H5P_DEFAULT, use_custom_vol_g ? &vol_info_g : NULL,
                                        use_custom_vfd_g ? &vfd_info_g : NULL)) < 0) {
            error_msg("unable to create FAPL for file access\n");
            h5tools_setstatus(EXIT_FAILURE);
            goto done;
        }
    }

[jhendersonHDF]

H5dump doesn't need to do anything about the environment variable. That's the entire point of the environment variable.

[jhendersonHDF]

To be clear, when the HDF5_VOL_CONNECTOR environment variable is set, it replaces the default VOL connector on File Access Property Lists. Therefore, h5dump doesn't need to pay attention to use_custom_vol_g because it doesn't need to setup a custom File Access Property List. It will just use the default one pointed to by H5P_DEFAULT which will already have the VOL set on it.

[hyoklee]

I just want to see a consistent behavior from the end-user's perspective.
Is --vol-name="daos" same as export HDF5_VOL_CONNECTOR=daos or not?

[jhendersonHDF]

When it eventually gets down to opening the file, yes both the command-line option and setting the environment variable are supposed to function the same way by just loading the DAOS VOL. If they do not function the same way, it's almost certainly a bug in the tools, but make sure you have a clean environment when testing that. Also, enable-vol is not a valid command-line option.

[mattjala]

Not a bug - closing.