Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove passwords from build image #45

Closed
jreadey opened this issue Mar 31, 2020 · 1 comment
Closed

Remove passwords from build image #45

jreadey opened this issue Mar 31, 2020 · 1 comment

Comments

@jreadey
Copy link
Member

jreadey commented Mar 31, 2020

Including usernames and passwords as part of the Docker image is problematic - for one it makes it impossible to distribute images via Docker hub or other public repo.

Rather than building in the password file, either mount the file (for Docker deployments) or create a secret (for Kubernetes).

@jreadey
Copy link
Member Author

jreadey commented Mar 31, 2020

Docker compose files have been updated to mount password file. E.g: https://github.com/HDFGroup/hsds/blob/master/docker-compose.yml.
And Kubernetes_deployment scripts use password secret.

@jreadey jreadey closed this as completed Mar 31, 2020
@jreadey jreadey mentioned this issue Mar 31, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant