Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes NullTransformer and col_meta. #30

Closed
ManuelAlvarezC opened this issue Jul 26, 2018 · 0 comments
Closed

Add attributes NullTransformer and col_meta. #30

ManuelAlvarezC opened this issue Jul 26, 2018 · 0 comments
Assignees
@ManuelAlvarezC
Labels
internal The issue doesn't change the API or functionality
Milestone
0.1.3

Comments

@ManuelAlvarezC
Copy link
Contributor

Transformers create NullTransformer when called with missing param.

The missing param should be made an attribute, and at init time,create an instance of NullTransformer in another attribute if proceeds.

Also, col_meta should be passed at init time and not on transform or fit calls.
@ManuelAlvarezC ManuelAlvarezC added the internal The issue doesn't change the API or functionality label Jul 26, 2018
@ManuelAlvarezC ManuelAlvarezC self-assigned this Jul 26, 2018
@ManuelAlvarezC ManuelAlvarezC added this to the 0.1.1 milestone Aug 24, 2018
@csala csala modified the milestones: 0.1.1, 0.2.0 Aug 29, 2018
@csala csala removed this from the 0.2.0 milestone Oct 11, 2018
@ManuelAlvarezC ManuelAlvarezC added this to the 0.2.0 milestone Oct 29, 2018
@JDTheRipperPC JDTheRipperPC modified the milestones: 0.2.0, 0.1.3 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManuelAlvarezC ManuelAlvarezC

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.1.3
Development

No branches or pull requests
3 participants
@csala @ManuelAlvarezC @JDTheRipperPC