Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gunsmith Pouch #2

Closed
UndeadZeratul opened this issue Jun 17, 2023 · 5 comments · Fixed by #5
Closed

Add Gunsmith Pouch #2

UndeadZeratul opened this issue Jun 17, 2023 · 5 comments · Fixed by #5
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@UndeadZeratul
Copy link
Member

It would certainly fit thematically to include a pouch to store all your precious crafting materials, at least. Since the URL was removed from Cozi's Offworld Wares, it also makes sense to migrate it here for the time being.

https://github.com/Deadondev/Cozis-Offworld-Wares/blob/main/zscript/Items/LogiBag.zsc

@Cryomundus
Copy link
Member

I'd recommend using the sprites from the gunsmith pouch: https://dastrukar.gitlab.io/hddons-list/#gunsmithpouch-mohl as it'll be easier to acquire permission for it, as its still a bit too early to consider offworld-wares's stuff abandoned, and I'd rather avoid upsetting folks if they come back and see their stuff nicked. Otherwise, yeah, sounds good!

@UndeadZeratul
Copy link
Member Author

That's fair, I agree that I we shouldn't just yank other repository's stuff without permission, however I did notice a bit of an absence with Offworld Wares which makes it a bit stickier of a situation.

I can reach out to Skelegant as they did the artwork for the original, and honestly I kind of like the fannypack look to it.

@UndeadZeratul
Copy link
Member Author

Taking a look at the Gunsmith Pouch, I do agree that the two of those pouches (the purse for the merchant, too) would do better as I forgot the Logistics Bag held much more stuff than simply crafting ingredients.

We can reach out to Mohl/Skelegant to see if they're both cool with using their code/assets.

@UndeadZeratul UndeadZeratul changed the title Add Logistics Bag from Cozi's Offworld Wares? Add Gunsmith Pouch Jun 22, 2023
@UndeadZeratul
Copy link
Member Author

I was able to get permission from Mohl to use the Gunsmith Pouch code, now we just need permission from Skelegant to use their art assets.

@UndeadZeratul
Copy link
Member Author

Skelegant also gave their permission to use their sprites, so I'll look into adding the Gunsmith Pouch at some point

@UndeadZeratul UndeadZeratul self-assigned this Jun 22, 2023
@UndeadZeratul UndeadZeratul linked a pull request Jun 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants