Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect changed manga URLs from Asura Scans #238

Closed
Zervox opened this issue Aug 22, 2023 · 8 comments
Closed

Redirect changed manga URLs from Asura Scans #238

Zervox opened this issue Aug 22, 2023 · 8 comments
Labels
bug Something isn't working website Issues related to websites

Comments

@Zervox
Copy link

Zervox commented Aug 22, 2023

Asurascans needs to have a setting for the site which allows a regex replace of

url = RegexReplace(url, '/[0-9]+-', '/'..settingsid..'-') before checking/connection
too many of the links does not allow non /number- id to be reached

alternatively to support other websites that does the same thing, allow to mass edit bookmark urls using regex

@HDoujinDownloader
Copy link
Owner

To make sure I understand correctly-- It seems AsuraScans changed the format of their URLs, and your bookmarks are no longer pointing to the right place anymore?

Could you send me some example URLs to look at (e.g. before and after fixing the URL)?

@Zervox
Copy link
Author

Zervox commented Aug 23, 2023

https://asura.nacm.xyz/manga/1901917615-drug-eating-genius-mage/

it's specifically the "/1901917615-"
they tend to change this regularly and accessing it through https://asura.nacm.xyz/manga/drug-eating-genius-mage/
etc is simply not possible for alot of the links
in some cases you can just do https://asura.nacm.xyz/manga/other-manganame-here but in others you can't, so typically it is better for consistency to just swap the /1901917615-

@HDoujinDownloader HDoujinDownloader added bug Something isn't working website Issues related to websites labels Aug 24, 2023
@HDoujinDownloader HDoujinDownloader changed the title Asura Redirect changed manga URLs from Asura Scans Aug 24, 2023
@HDoujinDownloader
Copy link
Owner

All right, I updated the module to get the current numeric prefix and automatically apply it to URLs before attempting to access them. For this to work, you also need to be using the latest pre-release.

Let me know if there are any problems!

@mrstan3772
Copy link
Contributor

This tends to reset all bookmarked chapters for publications that are redirected to another URL. Otherwise, create a duplicate bookmark with the new URL.

Redirect URLs Examples:
https://asuracomics.com/manga/2091190535-academys-undercover-professor => https://asuracomics.com/manga/4243005272-academys-undercover-professor
https://asuracomics.com/manga/2091190535-life-of-a-magic-academy-mage => https://asuracomics.com/manga/4243005272-life-of-a-magic-academy-mage

404 Error Example:
https://asuracomics.com/manga/2091190535-return-of-the-disaster-class-hero

@HDoujinDownloader
Copy link
Owner

This tends to reset all bookmarked chapters for publications that are redirected to another URL

I wonder if the chapter URLs change too? I notice they use a different numeric prefix from the manga they belong to, but I haven't checked if they actively change. If that's the case, they would be detected as new chapters.

@mrstan3772
Copy link
Contributor

This tends to reset all bookmarked chapters for publications that are redirected to another URL

I wonder if the chapter URLs change too? I notice they use a different numeric prefix from the manga they belong to, but I haven't checked if they actively change. If that's the case, they would be detected as new chapters.

Yes for https://asuracomics.com/manga/4243005272-life-of-a-magic-academy-mage/ Chapter 58 and 57 are not same prefix.

We need to find a way to ignore the prefix or accept unique regex pattern ?

@Zervox
Copy link
Author

Zervox commented Sep 15, 2023

this is because their way of updating the prefix is lagging behind. I've often noticed that not all of the comics update the prefix at the same time, and it seems like you are saying here that this applies also to the manga chapters. they will eventually end up all being the same.

personally I am glad just it finds the chapter then adds it as a new duplicate unlike before where I had to manually update the prefix for every single one, because then I won't have to look at all the red warnings unless the url has changed completely.

I've noticed that flamescans and luminous also uses this prefix but they are not updated the way it is for Asura, makes me wonder if they are only doing this semi automatically.

@HDoujinDownloader
Copy link
Owner

I'm not sure of the best way of handling this right now, but I'll give it some thought.

Stripping the prefix before comparing chapter URLs is an option, or comparing titles instead of URLs when checking for new chapters.

There is a workaround in the meantime you can try if you want: If you click the settings button on the top right of the bookmarks panel (accessible by going to Manga > Bookmarks), and then under "Checking", enable the "fast bookmark checking" setting. This disables the URL comparisons and just looks at the number of chapters to decide which ones are new (e.g. if there were 100 chapters before and 102 now, the last two will be considered new). This works well when the site never removes chapters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website Issues related to websites
Projects
None yet
Development

No branches or pull requests

3 participants