Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization of source files #10

Open
demitri opened this issue Dec 5, 2023 · 1 comment
Open

Organization of source files #10

demitri opened this issue Dec 5, 2023 · 1 comment

Comments

@demitri
Copy link
Contributor

demitri commented Dec 5, 2023

I would like to request that the source code files be reorganized for clarity and to facilitate inclusion into larger projects.

Currently all source code files are at the top level of the tar file / repository. There is a mixture of the code cfitsio library, platform-specific files, test files, etc. This makes it very difficult to identify which fall into which category and even source vs non-source files. Suggestion is to create a src directory (as is standard for Unix libraries), a cfitsio directory under that that contains the library source, tests, etc.

Reorganizing the files as above will address another difficulty. When one is attempting to build cfitsio as a dependent library into another program (or integrate it into another context) there is no guidance on which files are needed. For example, to build cfitsio into my application I needed to remove the following files while I only deduced by trial and error:

windumpexts.c 
install-sh 
cookbook.c 
testprog.c 
speed.c 
f77.inc
makefile.bc 
makefile.vcc 
vmsieee.c 
seem.c 
iter_var.c 
iter_a.c 
iter_b.c 
iter_c.c 
iter_image.c
fitscopy.c
fpack.c
funpack.c 
imcopy.c 
smem.c -> contains "main()"
@demitri demitri changed the title Organization of source release Organization of source files Dec 5, 2023
@bryanirby
Copy link
Collaborator

Thanks for the note, we'll take this into consideration for future development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants