-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automate pypi deploy #106
automate pypi deploy #106
Conversation
add deploy yml
make_deploy
make_deploy
make_deploy
make_deploy
make_deploy
it shouldn't release without tests passing, so this should either be moved to cci or the cci stuff needs to be moved to GHA. Also, doesn't this need some sort of "is this actually a new version" check beyond just "it's on the master branch"? |
.github/workflows/deploy.yml
Outdated
|
||
- name: pypi deployments | ||
run: | | ||
poetry build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this run after or in parallel to the unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @ojii suggested, putting to circleci workflow is probably better!
pypi will reject reupload of the same version. I think perhaps the GHA way would be to trigger on release rather than on push? If we wanted to hack this manually: |
Change from GHA to CircleCI deploy workflow
yes, I think moving to CircleCI is better. I made the tests required before deploy.
As @dimaqq suggested, the poetry will automatically reject if a same version is uploaded with 400 error, so I guess it will hint the necessity to bump the version. to determine which branch should trigger the action, is possible to specify with the following filter, sorry, I am not sure about the workflow for this, I will leave this part to you.
As for the |
This effort needs a new champion! |
i've tried to port cci to gha but got disillusioned by act https://github.com/HENNGE/aiodynamo/tree/gha |
Hmm unhashable VersionUnion was a poetry bug python-poetry/poetry#2340 |
My 2c: how about smaller scope: for example, only py3.9, only |
re: poetry failing, it's possible to specify exactly what poetry version to use: uses: abatilo/actions-poetry@v2.0.0
with:
poetry-version: ${{ matrix.poetry-version }} (perhaps a constant in this case) |
it's supposed to use 1.1.11 https://github.com/abatilo/actions-poetry/blob/7044c9c69e0265717d52471f66033b8d0e2a69ff/action.yml |
closes #105
Need to add
PYPI_TOKEN
to secret.