Raise asyncio.TimeoutError on httpx.TimeoutException #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojii
reviewed
Apr 19, 2022
|
thank you for this pull request. looks good, the test failures are clearly unrelated. I'll try to figure out how to fix them. |
|
To fix CircleCI, we have to fix the version of |
dimaqq
approved these changes
Apr 19, 2022
|
merging this despite CI failing, since I've fixed CI in other branches/PRs. |
|
@gunyarakun thank you again, released as 22.4 |
|
@ojii Thank you for your quick review and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
asyncio.TimeoutErroris handled in the client logic. Buthttpxwrapper raiseshttpx.TimeoutException.This pull request convert the exception and make the client be able to handle timeouts in
httpx.ref.)
httpxtimeout exceptionshttps://github.com/encode/httpx/blob/master/httpx/_exceptions.py#L7-L11
ref.) Custom HTTP Client Adaptor document
https://github.com/HENNGE/aiodynamo/blob/2e6c4716a3ac9fe5669bbdcaa73e6bbe0f73cfbb/docs/advanced.rst