Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for typing-extensions version 4 module #152

Open
nitishraghunathan opened this issue May 15, 2023 · 2 comments
Open

Support for typing-extensions version 4 module #152

nitishraghunathan opened this issue May 15, 2023 · 2 comments

Comments

@nitishraghunathan
Copy link

The latest version of aiodynamo (as of cutoff 2021-09) supports typing-extensions version 3.10.0.2. However, there is an issue where the self type is not recognized. To address this, it would be beneficial to add support for typing-extensions version 4 or higher, as this version provides explicit typing support.

@ojii
Copy link
Contributor

ojii commented May 16, 2023

However, there is an issue where the self type is not recognized.

aiodynamo doesn't use this type, so why is this an issue?

To address this, it would be beneficial to add support for typing-extensions version 4 or higher, as this version provides explicit typing support.

Python 3.7, the reason we even have the (conditional) typing-extensions dependency, will reach EOL in about a month, so I think the better move forward would be to drop 3.7 support and remove the typing-extensions dependency altogether.

@y26805
Copy link
Contributor

y26805 commented Oct 2, 2023

Since #161 removed support for Python 3.7, we can probably close this issue?
Also it looks like typing-extensions is required by mypy and black, and not something stated explicitly in our pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants