Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of coordinates #10

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Better handling of coordinates #10

merged 4 commits into from
Jun 14, 2021

Conversation

philbull
Copy link
Collaborator

@philbull philbull commented Jun 7, 2021

This PR clarifies which coordinate systems are being assumed for the input variables (source position cosines crd_eq and time-dependent rotation matrices eq2tops), and fixes an ordering bug in a coordinate conversion for the non-pixel beam call.

@philbull philbull self-assigned this Jun 7, 2021
@philbull philbull added bug Something isn't working documentation Improvements or additions to documentation labels Jun 7, 2021
Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philbull, this is much needed. I've approved, but mentioned a couple of things to tidy up.

src/vis_cpu/conversions.py Outdated Show resolved Hide resolved
src/vis_cpu/vis_cpu.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #10 (f04e19f) into main (be9df1b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   45.00%   45.00%           
=======================================
  Files           6        6           
  Lines         320      320           
  Branches       49       49           
=======================================
  Hits          144      144           
  Misses        162      162           
  Partials       14       14           
Impacted Files Coverage Δ
src/vis_cpu/conversions.py 69.76% <ø> (ø)
src/vis_cpu/vis_cpu.py 80.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e4cc6...f04e19f. Read the comment docs.

@philbull philbull merged commit 0835ff3 into main Jun 14, 2021
@philbull philbull deleted the fix_az_za_coords branch June 14, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants