Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up parent classes so that they can be extended outside this project #43

Closed
jraoatlogic opened this issue Feb 27, 2019 · 3 comments
Closed

Comments

@jraoatlogic
Copy link

Hi,

I'd like to extend or use AVAssetTimeSelector and AssetVideoScrollView outside this project, basically use them to write something similar to TrimmerView. Right now I couldn't do this because the classes are not open, and some properties are internal (such as assetPreview).

Thanks

@HHK1
Copy link
Owner

HHK1 commented Mar 1, 2019

Hi,

I'm not sure about exposing the internals of the implementation inside the interface. What about forking this repo and creating your customised version of the TrimmerView ?
How much difference is there between what you're looking to make and the existing TrimmerView ?

@jraoatlogic
Copy link
Author

Hi,

That's alright, I already implemented it by copying the files into my own project and renaming them, so it's not a hindrance, just want to see if there're better ways to do it, if opening the class is not an option it's fine to close this issue. I'm implementing a video timeline/scrubber, similar to the timeline in Apple's Photo app's video playback UI.

Thanks

@HHK1
Copy link
Owner

HHK1 commented Mar 4, 2019

If you feel like this could be a nice addition to this Pod, feel free to open a PullRequest. Would be nice indeed to have a different UI option for this.

@HHK1 HHK1 closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants