Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech debt]: handle Cancel by grouping temporary changes and batch api calls #2287

Closed
11 tasks done
Tracked by #2193
fpigeonjr opened this issue May 8, 2024 · 4 comments
Closed
11 tasks done
Tracked by #2193

[tech debt]: handle Cancel by grouping temporary changes and batch api calls #2287

fpigeonjr opened this issue May 8, 2024 · 4 comments
Assignees
@fpigeonjr
Labels
Dev Frontend Ready Designers have created and finalized the designs, story has been refined, and ready for a Developer task task for an associated story or backlog item tech-debt Resolved technical debt (tooling, configuration, or workflow)

Comments

@fpigeonjr
Copy link
Contributor

fpigeonjr commented May 8, 2024 •
edited

UX Review conducted on 5/4/2024 revealed that confirmation modal to send changes to Division Director should happen later in the flow. User should be able to make temporary BLI changes and have the ability to cancel out of those changes and/or click Save changes and if they are financial changes then the confirmation modal should fire.

Tasks

  • refactor state to allow for temporary BLIs
  • [-] ensure create Agreement Wizard doesn't break
  • [-] experiment to see if BudgetLinesForm can manage form state
  • allow user to cancel temporary BLIs changes
  • refactor CRUD operations [Cancel Button]
    • Create
    • Read
    • Update
    • Delete
  • batch api calls for new BLIs via [Save Button]
    • New BLIs via POST
    • Existing BLIS via PATCH
    • handle deleted BLIs
@fpigeonjr fpigeonjr mentioned this issue May 8, 2024
Closed
32 tasks
@fpigeonjr fpigeonjr added task task for an associated story or backlog item tech-debt Resolved technical debt (tooling, configuration, or workflow) Dev Frontend Ready Designers have created and finalized the designs, story has been refined, and ready for a Developer labels May 8, 2024
@fpigeonjr fpigeonjr self-assigned this May 8, 2024
@fpigeonjr fpigeonjr mentioned this issue May 8, 2024
Merged
9 tasks
@fpigeonjr
Copy link
Contributor Author

fpigeonjr commented May 10, 2024 •
edited

  • Cancelling out of changes is now supported
  • Saving changes is now also working as before
  • TODO: make sure the wizard is not breaking
  • TODO: handle (hard) deleting of BLIs

@fpigeonjr
Copy link
Contributor Author

  • hard deleting BLIs is now supported

@fpigeonjr
Copy link
Contributor Author

  • 500 server errors resolved
  • add logix on PATCH only BLIs that have changes

@fpigeonjr
Copy link
Contributor Author

  • will need to move state higher in the wizard since going back loses any created BLIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpigeonjr fpigeonjr

Labels
Dev Frontend Ready Designers have created and finalized the designs, story has been refined, and ready for a Developer task task for an associated story or backlog item tech-debt Resolved technical debt (tooling, configuration, or workflow)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fpigeonjr