Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Frontend API Calls should be kept under the Service folder #917

Closed
Kajol-Kumari opened this issue May 18, 2024 · 12 comments
Closed
Assignees
Labels
bug Something isn't working frontend This issue is related to frontend gssoc GSSoC'24 Label

Comments

@Kajol-Kumari
Copy link
Member

Kajol-Kumari commented May 18, 2024

Describe the bug
Currently, all the API calls is taking place atleast twice, one for normal flow and one for admin.

Expected behavior
We should keep all the api calls in a single folder service and then reuse the same code for all the places.

This issue just a placeholder as there are multiple folders that needs refactoring, so anyone who claims this issue, can pick one folder at a time, i will tag them here and then raise an issue for that, it will be given level 2 and then start working.

Folders Assignee
about @Hemu21
admin @Faizanusmani06
Broadcast @Hemu21
ContactUs @Hemu21
Faq @shivamgaur99
Q&A @devmusiczz
Resources @Hemu21
@Kajol-Kumari Kajol-Kumari added bug Something isn't working frontend This issue is related to frontend gssoc GSSoC'24 Label labels May 18, 2024
@Kajol-Kumari Kajol-Kumari pinned this issue May 18, 2024
@Kajol-Kumari Kajol-Kumari added the level2 Bug fixing, adding small features. label May 18, 2024
@Faizanusmani06
Copy link

Hey @Kajol-Kumari Please assign the admin folder to me.

@devmusiczz
Copy link

Hey @Kajol-Kumari I’ll take the QnA folder for refactor. Please assign this to me.

@Kajol-Kumari
Copy link
Member Author

@Faizanusmani06 and @devmusiczz please feel free to open the respective issue and continue on the same, Happy Learning :)

@Hemxnt
Copy link

Hemxnt commented May 23, 2024

assign me this issue

@Kajol-Kumari
Copy link
Member Author

@Hemxnt u need to mention the module, please go there issue description properly

@Hemu21
Copy link
Contributor

Hemu21 commented May 25, 2024

@Kajol-Kumari can you please assign me the contactUs folder.

@Hemu21
Copy link
Contributor

Hemu21 commented May 28, 2024

@Kajol-Kumari can you please assign me the about folder

@shivamgaur99
Copy link
Contributor

@Kajol-Kumari can you please assign me faq folder

@Kajol-Kumari
Copy link
Member Author

@shivamgaur99 / @Hemu21 assigned the respective modules, please feel free to open the respective issue and continue on the same, Happy Learning :)

@Hemu21
Copy link
Contributor

Hemu21 commented May 30, 2024

@Kajol-Kumari can you please assign me the resources folder. If possible can you please assign me the Broadcast also

@Hemu21
Copy link
Contributor

Hemu21 commented May 31, 2024

@Kajol-Kumari can you please assign me the Broadcast folder

@shivamgaur99
Copy link
Contributor

shivamgaur99 commented Jun 4, 2024

@Kajol-Kumari Since the FAQ folder also contains Q&A-related files, I worked on both FAQ and Q&A in my recent pull request. Can you check it? I didn't see that anyone is already assigned for Q&A.
I thought it was part of the FAQ folder.

@Kajol-Kumari Kajol-Kumari self-assigned this Jun 4, 2024
@Kajol-Kumari Kajol-Kumari removed the level2 Bug fixing, adding small features. label Jun 4, 2024
@Kajol-Kumari Kajol-Kumari unpinned this issue Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend This issue is related to frontend gssoc GSSoC'24 Label
Projects
None yet
Development

No branches or pull requests

6 participants