Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in file format caused by Fix #17 #22

Closed
kai-polsterer opened this issue May 29, 2019 · 1 comment
Closed

Inconsistency in file format caused by Fix #17 #22

kai-polsterer opened this issue May 29, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kai-polsterer
Copy link
Member

It seems that changes introduced in Fix #17 have created an inconsistency in the header parsing.

All files must currently have a mandatory header ending with "# END OF HEADER". Therefore the data format description has to change.

  • In UtilitiesLib/InputData.cpp line 367 the break criterion has to change and the clause has to be rewritten to seek correctly for the pattern.
  • In SelfOrganizingMapLib/FileIO.h line 28 when writing a SOM it has to be ensured that at least an empty header is written even, if the header was empty before or the SOM was newly created
  • In SelfOrganizingMapLib/SOM.cpp line 72 ff. when reading a SOM the hexagonal format is not supported and multidimensional neurons do not work.

perhaps all operations concerning header should be move to a single dedicated class handling all header operation, so future changes can be realized easier.

Currently the initialization with a SOM is broken for this particular reason, above. When printing the parameters of PINK while starting, it would help to print out the filename used for initialisation, too.

@BerndDoser
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants