Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to the footer #91

Merged
merged 5 commits into from
May 26, 2024
Merged

Add license to the footer #91

merged 5 commits into from
May 26, 2024

Conversation

longlin10086
Copy link
Member

📝 描述

✅ 检查清单

  • 是否在合适的文件夹上传?

  • 是否获得了必要的许可?

  • 文件命名是否符合规范?
  • 是否添加了 README.md 文件以帮助其他人理解你的文件?(可选)

🤔 附加信息

In issue #20 @kowyo had raised this proposal, so I just added the license to the page footer.
Here it looks like:
截屏2024-05-13 02 16 00

@longlin10086 longlin10086 requested a review from kowyo May 12, 2024 18:21
@longlin10086 longlin10086 linked an issue May 12, 2024 that may be closed by this pull request
@kowyo
Copy link
Member

kowyo commented May 12, 2024

Thanks for the PR. My origin idea would be adding the license in the end of the article, instead of the bottom of the whole website, which is also a convention of many blog themes. So I might work on it later, anyway, your contribution is still appreciated.

@kowyo
Copy link
Member

kowyo commented May 24, 2024

Will close the PR if 4019e10 looks good to you. Otherwise we can still have some work on it.

@kowyo kowyo closed this May 25, 2024
@kowyo kowyo reopened this May 26, 2024
Copy link
Member

@kowyo kowyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have referred to the practices of https://creativecommons.org and https://vuejs.org, and believe that placing the copyright notice at the bottom of the page is also a very good practice. Thanks for the PR, @longlin10086.

@kowyo kowyo merged commit e74e631 into HITSZ-OpenAuto:main May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license with a widget in Hextra
2 participants