Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pos_stats extraction #75

Merged
merged 3 commits into from Dec 5, 2022
Merged

Fix pos_stats extraction #75

merged 3 commits into from Dec 5, 2022

Conversation

rbroc
Copy link
Contributor

@rbroc rbroc commented Nov 29, 2022

closes #74

Log:

  • map pos_stats -> pos_proportions in __unpack_extensions, and adapt conditional logic accordingly
  • fix and simplify iterative metric extraction in Extractor init method (all metrics which do not throw an error should work with __unpack_extension)

@HLasse
Copy link
Owner

HLasse commented Dec 5, 2022

Thanks a lot for the PR, Roberta! 🙌

@HLasse
Copy link
Owner

HLasse commented Dec 5, 2022

@rbroc can I get you to update the minor version in the about.py file? I don't have access to make changes to your branch :)

@rbroc
Copy link
Contributor Author

rbroc commented Dec 5, 2022

updated patch as per slack conversation ;)

@HLasse
Copy link
Owner

HLasse commented Dec 5, 2022

Amazing, thanks! Merging it in

@HLasse HLasse merged commit b189234 into HLasse:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extract_df not working for pos_stats in v 1.1.0
2 participants
@rbroc @HLasse