Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to expand concept subset in datasets.py #141

Closed
Sigfried opened this issue Sep 29, 2022 · 3 comments
Closed

Need to expand concept subset in datasets.py #141

Sigfried opened this issue Sep 29, 2022 · 3 comments
Assignees

Comments

@Sigfried
Copy link
Collaborator

Having problems with missing concepts and missing links between concepts... can explain later.

What I think we should do is expand the subset of concepts in prepped files to: all of the concepts appear in the concept_ancestor table where either the ancestor_concept_id or the descendant_concept_id is included in the concept_set_members table. Right

@joeflack4
Copy link
Member

Makes sense to me so far! Will learn more later on.

@Sigfried
Copy link
Collaborator Author

Weird: out of 78,558,033 rows in the concept_ancestor table, 22% of the ancestor_concept_ids are in concept_set_members (what we're saving now), but 61% of descendant_concept_ids are. At that point, maybe it's not worth filtering it at all.

@Sigfried
Copy link
Collaborator Author

fixed earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 5. Done
Development

No branches or pull requests

2 participants