Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with checkboxes on rows in ComparisonDataTable #191

Closed
Sigfried opened this issue Dec 20, 2022 · 3 comments
Closed

problem with checkboxes on rows in ComparisonDataTable #191

Sigfried opened this issue Dec 20, 2022 · 3 comments
Assignees

Comments

@Sigfried
Copy link
Collaborator

Getting errors with codeset_id 419757429, which is currently included in the Example Comparison set of cset ids. Need to figure out why. This is occurring in both the develop branch and the db branch. I don't remember it being an issue before we switched to working on the db branch, so maybe the problem is arising from some change in the data rather than a problem with code. Or maybe if we go to an older commit on the development branch the problem will disappear.

@Sigfried
Copy link
Collaborator Author

Sigfried commented Dec 20, 2022

Ok -- when I go back to 899ebb3 in October, the problem goes away. Will try to place the change where it started.

The problem started here: 0e1af9a. It's a big merge, which is going to make it hard to figure out what the problem is.

Ok, traced it back further than the merge to a2346ee. Or, at least at that commit there's a different problem. And it's another big commit. Not going to be easy to find the problem there.... And since the error is totally different

Uncaught ReferenceError: Cannot access 'allConcepts' before initialization
    at makeRowData (Csets.js:107:1)
    at Csets.js:95:1

and had to have been fixed soon after, need to trace it downstream....

@Sigfried
Copy link
Collaborator Author

Hmm... maybe 7a2b9bf didn't entirely fix the problem. These messages went away for some reason briefly, but after I reloaded everything (I guess) they came back:
Screen Shot 2022-12-21 at 9 21 25 AM

@joeflack4
Copy link
Member

joeflack4 commented Dec 21, 2022

Concept with ID 256716 is problematic.
Why is it problematic?
We looked at its appearances in the old cr-hierarchy JSON we saved as a static file and are returning, and the new cr-hierarchy. But in the instances where it appears, it's the same structure in both.
Test url: http://localhost:3000/cset-comparison?codeset_id=400614256&codeset_id=411456218&codeset_id=419757429&codeset_id=484619125

Sigfried referenced this issue Jan 6, 2023
  distinct_person_cnt, approx_distinct_person_count, and more. Think
  I've cleaned that up and most of the bugs are gone.
  Having something wierd with the ConceptSetCards now: they all just
  say: "Contributors 0: huh?"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 5. Done
Development

No branches or pull requests

2 participants