Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add a flag to transmit without further question #3

Closed
agbcix opened this issue Nov 25, 2022 · 2 comments
Closed

Improvement: Add a flag to transmit without further question #3

agbcix opened this issue Nov 25, 2022 · 2 comments

Comments

@agbcix
Copy link

agbcix commented Nov 25, 2022

I understand that using --transmit has some security implications. Thus there is a prompt to ensure that the user needs to make an informed decision.

I see a use case for some kind of batch mode. I.e. someone who doesn't want to be prompted for approval.

I can imagine to have some --force-transmit or --transmit -y flag.

Using echo "yes" | augsburg-traceroute --transmit will do the same -- which may be considered as argument pro and contra at the same time.

@vhein99
Copy link
Collaborator

vhein99 commented Nov 26, 2022

I like the idea of implementing a switch for proceeding without further input,
it certainly makes the program a better fit for use in automated scripts.

I personally like the idea of a generic -y switch,
should more prompts be added to the client in the future (which is unlikely, but still possible)
we can handle them all with the single switch, instead of implementing a specific force flag like --force-transmit
for each of those prompts.

@vhein99
Copy link
Collaborator

vhein99 commented Nov 26, 2022

Requested improvement implemented by commit ea828f6.
The user can now specify the -y / --assume-yes switch to run the program in batch mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants