Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor monitoring to "plugins" #31

Closed
graeme-a-stewart opened this issue Apr 13, 2018 · 1 comment
Closed

Refactor monitoring to "plugins" #31

graeme-a-stewart opened this issue Apr 13, 2018 · 1 comment
Assignees

Comments

@graeme-a-stewart
Copy link
Member

As was noted in #2 the structure of prmon makes it difficult to easily add or remove parts of the monitoring.

I think this could be refactored along the following lines:

  • Each piece of the monitoring is a class instance (cpumon, netmon, iomon, ...)
  • Each of these classes implements an monitoring interface that provides the standard components need by prmon (e.g., print text file headers, get statistics, print JSON entries)

Then prmon can keep a vector of the enabled instances and just loop over them to assemble the requisite monitoring in a flexible way.

@graeme-a-stewart
Copy link
Member Author

Fixed in #37, although at the moment no runtime switching of monitoring modules is done, it's much easier to support this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant