Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Python version in runtime #390

Closed
johpiip opened this issue Nov 2, 2021 · 0 comments · Fixed by #425
Closed

Check Python version in runtime #390

johpiip opened this issue Nov 2, 2021 · 0 comments · Fixed by #425
Labels
enhancement New feature or request
Milestone
v4.1

Comments

@johpiip
Copy link
Contributor

johpiip commented Nov 2, 2021 •
edited
Loading

Instead of checking Python version in the UI (relevant PR: HSLdevcom/helmet-ui#122), should we check it in the model system in runtime using sys.version_info just like in this stackOverflow question? What do you think?

  • 4.0.x: sys.version_info.major == 2 and sys.version_info.minor == 7
  • 4.1.x: sys.version_info.major == 3 and sys.version_info.minor == 7
@zptro zptro added this to the v4.1 milestone Dec 1, 2021
@zptro zptro added the enhancement New feature or request label Dec 2, 2021
@zptro zptro linked a pull request Jan 4, 2022 that will close this issue
Add python version check #425
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.1
Development

Successfully merging a pull request may close this issue.

Add python version check HSLdevcom/helmet-model-system
2 participants
@zptro @johpiip