Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KELA codes for other municipalities are not understood #416

Closed
zptro opened this issue Dec 2, 2021 · 0 comments · Fixed by #431
Closed

KELA codes for other municipalities are not understood #416

zptro opened this issue Dec 2, 2021 · 0 comments · Fixed by #431
Labels
invalid This doesn't seem right
Milestone
v4.1

Comments

@zptro
Copy link
Collaborator

zptro commented Dec 2, 2021 •
edited
Loading

If unknown KELA codes are found, "Municipality KELA code not found for nodes..." is logged.

We should add some more KELA codes (e.g., Forssa), because some nodes are placed there even though these municipalities do not belong to the model area. We then need to handle these nodes correctly, exempting them from area aggregations.
@zptro zptro added the invalid This doesn't seem right label Dec 2, 2021
@zptro zptro added this to the v4.1 milestone Jan 4, 2022
@zptro zptro linked a pull request Jan 17, 2022 that will close this issue
Add KELA codes and handle them which lack zone aggregation #431
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
v4.1
Development

Successfully merging a pull request may close this issue.

Add KELA codes and handle them which lack zone aggregation HSLdevcom/helmet-model-system
1 participant
@zptro