Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research: Upgrade react-map-gl to v7 #657

Closed
1 task done
eleksi opened this issue Mar 1, 2022 · 3 comments
Closed
1 task done

Research: Upgrade react-map-gl to v7 #657

eleksi opened this issue Mar 1, 2022 · 3 comments
Assignees
Labels
Projects

Comments

@eleksi
Copy link
Contributor

eleksi commented Mar 1, 2022

Performance updates etc.

Edit:
We no longer (probably) have to use react-map-gl-draw, switch to using se mapbox-gl-draw directly, as noted in patch notes.

https://github.com/visgl/react-map-gl/tree/7.0-release/examples/draw-polygon

15.6. additions

See also another similar fixed issue: visgl/react-map-gl#1892

Note; This is a research ticket, create implementation ticket within this ticket.

@eleksi eleksi created this issue from a note in Jore4 (Project backlog) Mar 1, 2022
@ellinooraikaheimo ellinooraikaheimo added this to the Q2 2022 milestone Mar 10, 2022
@ellinooraikaheimo ellinooraikaheimo added the Routes and lines Module. (Reitit ja linjat) label Mar 10, 2022
@ossiberg ossiberg moved this from Project backlog to Backlog prioritised in Jore4 Mar 24, 2022
@eleksi eleksi added the blocked label Apr 4, 2022
@github-actions github-actions bot removed the blocked label Apr 4, 2022
@ellinooraikaheimo ellinooraikaheimo moved this from Backlog prioritised to Sprint Backlog in Jore4 Jun 21, 2022
@ellinooraikaheimo ellinooraikaheimo moved this from Sprint Backlog to Backlog prioritised in Jore4 Jun 21, 2022
@tuokait tuokait self-assigned this Jun 29, 2022
@tuokait tuokait moved this from Backlog prioritised to In progress dev in Jore4 Jun 29, 2022
@tuokait
Copy link

tuokait commented Jun 30, 2022

This is partially done at https://github.com/HSLdevcom/jore4-ui/tree/wip/upgrade-react-map-gl
Things that are still broken are mentioned in this commit message: HSLdevcom/jore4-ui@2ce7dc9

@tuokait
Copy link

tuokait commented Aug 9, 2022

Seems like react-mapl-gl-draw does not (currently?) support react-map-gl v7. More details mentioned in commit messages at https://github.com/HSLdevcom/jore4-ui/tree/wip/upgrade-react-map-gl

@ellinooraikaheimo ellinooraikaheimo changed the title Upgrade react-map-gl to v7 Research: Upgrade react-map-gl to v7 Dec 19, 2023
@Perholehto Perholehto self-assigned this Jan 5, 2024
@Perholehto
Copy link

Suggesting that we update straightaway to react-map-gl version 7.1. There is no problems with backward compatibility in 7.1. It removes need for placeholder dependency and allows us to use maplibre-gl types in development. We should also remove dependency react-map-gl-draw and directly use mapbox-gl-draw instead (visgl/react-map-gl#2053 , https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-draw/). react-map-gl-draw is a wrapper for mapbox-gl-draw but in 7.1 we can use it directly so it’s not mandatory to use the wrapper. Also react-map-gl-draw is not compatible with 7.x versions. We can use https://github.com/HSLdevcom/jore4-ui/tree/wip/upgrade-react-map-gl branch for starting point or guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Jore4
On hold 3rd party
Development

No branches or pull requests

5 participants