-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thermometer rendering based on current and target values #250
Comments
Starting this. from the sky...muahahahah.... |
@joelhulen Is there any reason I can't change the CampaignImpactType to an enum? |
@MisterJames Absolutely no reason not to. In fact, I was going to do that after creating a class to hold those types of objects (enums and structs). I had brought it up at one point, but it was tabled while we were working through other issues. I also like getting rid of magic strings. I think a static class named something like "EnumsAndStructs" or "WellKnownNames" would be clear as to its intent. |
Beauty, thanks @joelhulen. I'll do the enum part here as part of this issue. |
It you want to open a new issue on improving the look of that and assign it to me I'll d3 up something |
@stimms done. Feel free to d3 the heck out of it 👽 |
Two aspects to this:
From #35.
The text was updated successfully, but these errors were encountered: