Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thermometer rendering based on current and target values #250

Closed
1 of 2 tasks
MisterJames opened this issue Nov 8, 2015 · 7 comments
Closed
1 of 2 tasks

Add thermometer rendering based on current and target values #250

MisterJames opened this issue Nov 8, 2015 · 7 comments
Assignees
Labels

Comments

@MisterJames
Copy link
Contributor

Two aspects to this:

  • data entry on the Campaign Edit page
  • rendering the thermometer on the public campaign page (for numeric impact types)

From #35.

@MisterJames
Copy link
Contributor Author

Starting this. from the sky...muahahahah....

@MisterJames
Copy link
Contributor Author

@joelhulen Is there any reason I can't change the CampaignImpactType to an enum?

@joelhulen
Copy link
Contributor

@MisterJames Absolutely no reason not to. In fact, I was going to do that after creating a class to hold those types of objects (enums and structs). I had brought it up at one point, but it was tabled while we were working through other issues.

I also like getting rid of magic strings. I think a static class named something like "EnumsAndStructs" or "WellKnownNames" would be clear as to its intent.

@MisterJames
Copy link
Contributor Author

Beauty, thanks @joelhulen. I'll do the enum part here as part of this issue.

@MisterJames
Copy link
Contributor Author

Update...first rev will look something like this:

image

This will just be a temp thing until we get a better thermometer control in place.

@stimms
Copy link
Contributor

stimms commented Nov 12, 2015

It you want to open a new issue on improving the look of that and assign it to me I'll d3 up something

@tonysurma
Copy link
Member

@stimms done. Feel free to d3 the heck out of it 👽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants