Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web App - Volunteer - On the Volunteer Home page, not all fields marked as required are being enforced #692

Open
gmford opened this issue Aug 6, 2016 · 2 comments

Comments

@gmford
Copy link

gmford commented Aug 6, 2016

In the 'Report New Data' section, the 'Description' and 'Location' input fields are marked as required, but if I leave them blank and click 'Checkin', no error messages appear:
requirednoerror

@TheTopher
Copy link
Contributor

There are issues with this page that make the fix a larger project than defining identifying required fields.
Overview:
There are two sections of this page: 1) "Make a new commitment" and 2) "My Organization Resources". Both appear to be controlled by the same view model in: "ViewModels/VolunteerViewModel.cs.". This is causing issues with the validations of required fields on the page. When either the "Volunteer" or the "Checkin" button is pressed the validation errors appear in both sections of the screen. The best solution will be for the view models to be separated so that the areas of page are atomic (and can be reusable).

@gmford
Copy link
Author

gmford commented Aug 7, 2016

Is this related to #690?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants