Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workerpool to requirements #24

Merged
merged 2 commits into from Jul 15, 2021
Merged

Add workerpool to requirements #24

merged 2 commits into from Jul 15, 2021

Conversation

MichaIng
Copy link
Member

This allows to drop the static files from our /libs directory. The version/code matches 100%, as workerpool has never been updated since it was added to HTPC-Manager.

@MichaIng
Add workerpool to requirements
a29046e 
This allows to drop the static files from our /libs directory. The version/code matches 100%, as workerpool has never been updated since it was added to HTPC-Manager.

Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng MichaIng added the enhancement New feature or request label May 13, 2021
@MichaIng
Delete libs/workerpool directory
79dd138 
This has been added to requirements.txt instead.
@MichaIng MichaIng requested a review from gmiranda May 13, 2021 21:41
@MichaIng MichaIng self-assigned this May 13, 2021
@MichaIng
Copy link
Member Author

MichaIng commented Jun 12, 2021 •
edited

One problem: Since the updater does not (and usually cannot) call pip to update dependencies, removing the directory will break HTPC-Manager on update. In case Git was used to install it, it should be possible to add libs/workerpool to .gitignore to keep it installed, although only from next update on 🤔. And when it was installed via archive (without Git), then .gitignore isn't respected either: https://github.com/HTPC-Manager/HTPC-Manager/blob/master2/htpc/updater.py#L529-L572

Not sure currently how to get rid of such obsolete Python modules from the repo. I'll need to run some tests.

@MichaIng
Copy link
Member Author

I think it's okay to merge this. The local workerpool directory is only removed if the "Git Cleanup?" option is enabled, which is not the default. What do you think?

@MichaIng MichaIng merged commit 9968256 into master2 Jul 15, 2021
@MichaIng MichaIng deleted the MichaIng-workerpool branch July 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmiranda gmiranda Awaiting requested review from gmiranda

Assignees

@MichaIng MichaIng

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MichaIng