-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCUSSION] Context class in doc_writer.py #78
Comments
The format of context was changed in commits by previous contributors and there hasn't been any problem so far. The only problem is failing test cases. I don't think reverting back the changes in doc_writer just to fix the test is a good idea. We should rather update the tests according to the newly made changes. The Context class here is used to generate context for HydraDoc and HydraEntrypoint class. Test cases in core repo should be updated. Also we might consider it's expansion or migration to pytest in future. |
@farazkhanfk7 Yes, changing context is not a good idea for falling tests, I just highlighted the reason for failing. |
Yes, even I was thought the same at first when I was working to fix the test cases. But this format works totally fine. These changes were made in this PR where the format of these URIs were changed. |
@priyanshunayan Can you please help us in understanding this? |
We had taken a call to use expanded Does this answer your question? |
@priyanshunayan, got your point It makes hydrus more generic to everyone. Thanks for your help. |
I'm submitting a
Current Behaviour:
class Context
in doc_writer.py is creating context in this format :And we are expecting it in this format:
Probably that's why the tests in doc_writer.py are failing
I have a concern should we add the base address as well in the context for classes, collection & properties?
"vocab" : base_adderss
Do you want to work on this issue?
yes, If it is required to add.
The text was updated successfully, but these errors were encountered: