Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node compatabillity #1

Closed
benrudolph opened this issue Nov 5, 2014 · 2 comments
Closed

Node compatabillity #1

benrudolph opened this issue Nov 5, 2014 · 2 comments

Comments

@benrudolph
Copy link

Hi David,

This is awesome; I'd love this for JS. I was thinking it might be worthwhile to make it compatible for node and not just the browser as most file reading will be done on server. Also in terms of design, I'd suggest something like a callback function when the file has been read (ex: https://github.com/wdavidw/node-csv). Node is single threaded so it depends on making all the long running tasks (like file reading) as asynchronous tasks which can be completed without blocking the main thread. I can help out with PR if that'd be useful. I think we should adhere to the standard specified in CommonJS (http://en.wikipedia.org/wiki/CommonJS). Underscore and D3 are also good examples of JS libraries that are compatible on the server and the browser

@davidmegginson
Copy link
Member

Those are excellent suggestions -- thanks, Ben.

@davidmegginson
Copy link
Member

The hxl.load method already uses a callback. The hxl.wrap method doesn't, but since it wraps pre-parsed data, it shouldn't cause a synchronous delay.

Added #16 to review the compatibility guidelines later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants