Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style changing to black, isort, then yapf #27

Open
2 tasks
HYChou0515 opened this issue Nov 5, 2021 · 0 comments
Open
2 tasks

Coding style changing to black, isort, then yapf #27

HYChou0515 opened this issue Nov 5, 2021 · 0 comments
Labels

Comments

@HYChou0515
Copy link
Owner

TL;DR

Format code in this order

  1. black
  2. isort
  3. yapf

Test coding style in

  • CI test
  • pre-commit

Description

Current coding style is yapf only.
However yapf itself is not strict. (see example below)
To be more strict, but still stick to yapf style, using black first and then yapf seems a good way to go.
To make this realistic and practical, try adding them to CI test and pre-commit check.

yapf is not strict

Both style is considered fine in yapf

’single quoted’
“double quoted"
@HYChou0515 HYChou0515 added the CI label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant