Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags appear to be using OR logic when multiple tags are selected #1410

Closed
shanaqui opened this issue Nov 9, 2020 · 7 comments
Closed

Tags appear to be using OR logic when multiple tags are selected #1410

shanaqui opened this issue Nov 9, 2020 · 7 comments

Comments

@shanaqui
Copy link

shanaqui commented Nov 9, 2020

User report: "Some of the to-do's are tagged with "Cooking" and "Challenges", but still show up when "Self-Talk" and "Challenges" are selected. Also, the to-do's tagged with "Self-Talk" and "Challenges" still show up when "Cooking" and "Challenges" are active."

Device: Xiaomi Mi A3
Android Version: 29
AppVersion: Version 3.0.2 (2604)
User ID: 6cff2a6f-d8a0-407d-b768-8913c082f5b8
Level: 4
Class: warrior
Is in Inn: false
Uses Costume: false
Custom Day Start: 0
Timezone Offset: -60

Verified in my version of the app (3.1, build no. 2628). The web version uses AND logic and it would make sense to be consistent.

@saraolson
Copy link
Collaborator

saraolson commented Nov 9, 2020

me/phillips thoughts on this:
i don't want to change the logic to match web now just for consistency when we may upset the workflows of a bunch of users that are used to the way android works.

assuming this wasn't a sudden bug, android has used this logic for awhile and we haven't heard many complaints (neither me or phillip remember the last time we worked on filter logic). and/or logic is one of those things that works for some, doesn't work for others. android users have gotten used to the way it works, and we know that while some users are cross platform, the majority are not.

if this were a bug where suddenly the logic got switched, then yea i'm on board for switching it back. it doesnt seem thats the case yet, though correct me if im wrong, so would prefer leaving it the way the majority of our android users are used to.

@Alys
Copy link

Alys commented Nov 14, 2020

I've documented this Android app behaviour difference in the wiki (Tags > Multiple Tags and Features Across Clients).

@saraolson Does the behaviour on iOS match the website or the Android app?

@saraolson
Copy link
Collaborator

@Alys iOS uses the and logic, so when filtering to 'morning' and 'health' it will only show tasks that are tagged with both.

@Alys
Copy link

Alys commented Nov 16, 2020

@saraolson great, thanks! The wiki is correct for that.

@DavidMichelson2
Copy link

DavidMichelson2 commented Feb 1, 2021

@saraolson With all due appreciation for your contributions, I cannot imagine what benefit an "OR" instead of "AND" would serve--or, at least, that anyone would prefer it given the option of only one or the other.

I would imagine most people use the filter as I do: to describe characteristics of their current circumstances (e.g., in terms of location, time of day, personal mood) in order to identify the tasks best suited to their combination.

Even if there are users who might use the tags filtering in the sense of "OR," the workaround for this is far more practicable than the workaround for "AND." A user wishing to "OR" but only able to "AND" can simply run multiple searches, assessing their results additively and incrementally.

A user wishing to "AND" but only able to "OR," however, must somehow mentally SUBTRACT portions of the results. Since the tab labels aren't readily visible in the task lists, this means inspecting the details of each resulting task one by one!

Please, if there is any way possible to add support for "AND" on Android, I would be so very grateful.

@saraolson
Copy link
Collaborator

@DavidMichelson2 thank you for taking the time to add your feedback to this issue! we will definitely keep your points in mind when considering whether to change android's filtering logic.

@paulmand3l
Copy link

@DavidMichelson2 fwiw I’ve never thought to use tags like that and vastly prefer the “or” filtering of the android app the “and” filtering of the web app. I use the tags like categories and like to be able to see multiple categories at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants