Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Disable upcoming reminder if task is alredy done #1972

Closed
pwall2222 opened this issue May 10, 2023 · 5 comments
Closed

[Enhancement] Disable upcoming reminder if task is alredy done #1972

pwall2222 opened this issue May 10, 2023 · 5 comments

Comments

@pwall2222
Copy link

When you create a task and create this reminders:

  • In 30 min
  • In 1 hour
  • In 2 hour
    And you after 1 hour check off the task, the 2 hours reminder will still pop up even though the task is finished.
    (From what I have searched through the code, it's a matter of when completing a task in completeTaskForUser, to delete or disable the reminders)
@pwall2222 pwall2222 changed the title Disable upcoming reminder if task is alredy done [Enhancement] Disable upcoming reminder if task is alredy done May 10, 2023
@phillipthelen
Copy link
Member

The app checks if a task was completed before displaying the notification. Did you complete your task in the app or on the website? Otherwise that check might not be working correctly in your case.

@pwall2222
Copy link
Author

I'm checking it on my device, and I go look and the task is checked off alredy too but I still get the notification.

@saraolson
Copy link
Collaborator

haven't been able to reproduce on 4.2

@saraolson
Copy link
Collaborator

saraolson commented Jun 22, 2023

had a report of this from a user in regards to To Do reminders, which may be why we couldn't reproduce. we were testing daily reminders previously. will test this more thoroughly in the coming days and report back.

@saraolson
Copy link
Collaborator

We made some updates to the reminder system that may have improved this. When testing, i didn't receive the reminder for a ToDo i completed, and did receive one for the ToDo that hadn't been completed yet.

Gonna close this optimistically :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants